Add back support for sigv4 overrides #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows you to change the signature version used when signing requests for a particular service. This isn't strictly needed to communicate with various endpoints, any region specific signature versions are captured in _endpoints.json. However, with S3 we sometimes need to switch to sigv4 even if it otherwise wouldn't be required.
|
LGTM 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to change the signature version used when
signing requests for a particular service.
This isn't strictly needed to communicate with various endpoints,
any region specific signature versions are captured in _endpoints.json.
However, with S3 we sometimes need to switch to sigv4 even if it
otherwise wouldn't be required.
Looks like this code was still in botocore, it just was never updated to work with the
new v2 models. So this PR updates the handler to work with the new v2 format where
signature versions are specified in the metadata of a service (and is now camelCased).
cc @kyleknap @danielgtaylor