Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cargo-make to the SDK #110

Merged
merged 1 commit into from
Jun 20, 2023
Merged

add cargo-make to the SDK #110

merged 1 commit into from
Jun 20, 2023

Conversation

bcressey
Copy link
Contributor

@bcressey bcressey commented Jun 8, 2023

Issue number:
#108

Description of changes:
Add cargo-make to the SDK.

Testing done:
Confirmed that cargo make runs.

[builder@c35a9c5ba2b3 ~]$ env | grep CARGO_MAKE
CARGO_MAKE_DISABLE_UPDATE_CHECK=1

[builder@c35a9c5ba2b3 ~]$ cargo make empty
[cargo-make] INFO - cargo make 0.36.8
[cargo-make] INFO - Build File: Makefile.toml
[cargo-make] INFO - Task: empty
[cargo-make] INFO - Profile: development
[cargo-make] INFO - Running Task: legacy-migration
[cargo-make] INFO - Build Done in 0.12 seconds.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@bcressey
add cargo-make to the SDK
995260a 
The new unified build tool will wrap `cargo make` invocations inside
the SDK, as a transitional step toward more fully encapsulating and
streamlining the build.

Export `CARGO_MAKE_DISABLE_UPDATE_CHECK` by default, so the command
will work as expected in a container with no network access. Updates
are expected to come from future releases of the SDK in any case.

Signed-off-by: Ben Cressey <bcressey@amazon.com>
@bcressey bcressey requested review from jpculp and webern June 8, 2023 17:47
@bcressey bcressey merged commit 03bc205 into bottlerocket-os:develop Jun 20, 2023
@bcressey bcressey mentioned this pull request Jun 21, 2023
Closed
@bcressey bcressey deleted the cargo-make branch March 4, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmrow zmrow zmrow approved these changes

@jpculp jpculp jpculp approved these changes

@webern webern webern approved these changes

@etungsten etungsten etungsten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bcressey @zmrow @jpculp @webern @etungsten