Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove variant sensitivity from 5.15 kernel #3905

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

bcressey
Copy link
Contributor

Issue number:
Related: #3883

Description of changes:
Move non-aws variants from the 5.15 to the 6.1 kernel. After the only in-tree users of the 5.15 kernel are aws variants, merge the aws-specific config into the main config and remove the variant sensitive marker from the package.

Although changing the kernel for a variant mid-stream is unusual, the update policy permits it for cases where the kernel will reach end-of-life before the variant.

Removing conditional compilation from the 6.1 kernel will be quite a bit more complicated. Landing this change first will limit that complexity to just the 6.1 kernel, rather than requiring a separate set of complicated changes for the 5.15 kernel shortly before it reaches end-of-life.

(A future change will move all the aws-k8s-* variants from the 5.15 to the 6.1 kernel. Currently that's blocked by #3459 and full confirmation that Lustre works as expected.)

Testing done:

❯ ./tools/diff-kernel-config -b HEAD^ -a HEAD -v aws-k8s-1.24 -o configs
...

config-aarch64-aws-k8s-1.24-diff:         0 removed,   0 added,   0 changed
config-x86_64-aws-k8s-1.24-diff:          0 removed,   0 added,   0 changed

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

The 5.15 kernel is nearing its end-of-life in upstream Amazon Linux.
Move vmware and metal variants that are still on 5.15 over to 6.1, to
ensure that they run a supported kernel until they reach end-of-life.

Signed-off-by: Ben Cressey <bcressey@amazon.com>
Now that the only in-tree users of the 5.15 kernel are aws variants,
merge the aws-specific config into the main config and remove the
variant sensitive marker from the package.

Signed-off-by: Ben Cressey <bcressey@amazon.com>
Copy link
Member

@larvacea larvacea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@bcressey bcressey merged commit 4f996ed into bottlerocket-os:develop Apr 22, 2024
33 checks passed
@bcressey bcressey deleted the kernel-5.15-invariant branch April 22, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants