Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum xarray version to 0.13.0 #106

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Conversation

johnomotani
Copy link
Collaborator

I propose bumping the minimum version of xarray to 0.13.0. I want to use the 'join' kwarg for concat which was introduced in 0.13.0.

@TomNicholas
Copy link
Collaborator

I'm using 0.14.1 so I expect this is fine

@ZedThree
Copy link
Member

Just noticed the list of packages for Travis -- is this just duplicating requirements.txt/setup.py? Could just pip install -r requirements.txt?

@johnomotani
Copy link
Collaborator Author

Just noticed the list of packages for Travis -- is this just duplicating requirements.txt/setup.py? Could just pip install -r requirements.txt?

One of the builds on Travis does do pip install -r requirements.txt. The explicit PIP_PACKAGES=... is for a second version that uses the minimum required version of each package. Would be nice if there's a neater way to do this, but pip is keener on giving you the newest possible version of each package!

@ZedThree ZedThree merged commit 1fba3fa into master Mar 20, 2020
@ZedThree ZedThree deleted the xarray-require-0.13.0 branch March 20, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants