Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String offset access syntax with curly braces (PHP 7.4 compat) #189

Merged
merged 1 commit into from
Jul 26, 2019
Merged

String offset access syntax with curly braces (PHP 7.4 compat) #189

merged 1 commit into from
Jul 26, 2019

Conversation

kornrunner
Copy link
Contributor

@kornrunner kornrunner commented Jul 22, 2019 •
edited
Loading

Array and string offset access syntax with curly braces is deprecated in PHP 7.4, this change will prevent notice from being issued.

Thanks!

@allejo allejo requested a review from a team July 23, 2019 00:28
@allejo
Copy link
Member

allejo commented Jul 23, 2019

Semi-related to this PR, do we want to wait for 7.4 to finalized or should we add 7.4snapshot to the list of Travis tests?

@kornrunner
Copy link
Contributor Author

7.4 has entered feature freeze, it makes sense to add 7.4snapshot to the list.

@kornrunner kornrunner mentioned this pull request Jul 23, 2019
Merged
@kornrunner
Copy link
Contributor Author

Based on #192 - this will need more updates

@kornrunner kornrunner force-pushed the master branch 2 times, most recently from 1b37f7a to ddf799b Compare July 23, 2019 19:37
@kornrunner
Copy link
Contributor Author

Rebased this one after #192 got merged in

@kornrunner kornrunner mentioned this pull request Jul 23, 2019
Merged
localheinz
localheinz approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kornrunner
Copy link
Contributor Author

I believe these changes cover the topic of the issue completely.

Remaining deprecation notices bubble up from bovigo/callmap#10 - and they can be sorted once that gets merged (and dependancy gets updated in this repository afterwards).

@allejo
Copy link
Member

allejo commented Jul 26, 2019 •
edited
Loading

@kornrunner Now that #194 has been merged into master and callmap updated, could you please rebase this on top of master and then we'll be able to finally confirm everything's working as expected with 7.4.

@kornrunner
Copy link
Contributor Author

Sure, it's done

@allejo allejo merged commit ab3605e into bovigo:master Jul 26, 2019
@allejo
Copy link
Member

allejo commented Jul 26, 2019

Thanks @kornrunner for all of your work to get us and our related projects to play nicely on 7.4 🎉

@allejo allejo mentioned this pull request Jul 29, 2019
Merged
@t0mmy742 t0mmy742 mentioned this pull request Dec 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allejo allejo allejo approved these changes

@localheinz localheinz localheinz approved these changes

@mikey179 mikey179 mikey179 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kornrunner @allejo @mikey179 @localheinz