Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insight config read causes error on CI #1221

Closed
sheerun opened this issue Apr 8, 2014 · 0 comments · Fixed by #1238
Closed

Insight config read causes error on CI #1221

sheerun opened this issue Apr 8, 2014 · 0 comments · Fixed by #1238
Labels
bug

Comments

@sheerun
Copy link
Contributor

sheerun commented Apr 8, 2014

I'm getting repeatable error on http://rails-assets.org

JSON::ParserError: 757: unexpected token at 'TypeError: Cannot read property 'optOut' of null 
at Object.Configstore.get (/home/app/app/releases/277b5e33bb87229e434663acc2b3ee90a9d8b308/node_modules/bower/node_modules/insight/node_modules/configstore/configstore.js:78:17) 
at Insight.Object.defineProperty.get (/home/app/app/releases/277b5e33bb87229e434663acc2b3ee90a9d8b308/node_modules/bower/node_modules/insight/lib/insight.js:31:22) 
at Object.setup (/home/app/app/releases/277b5e33bb87229e434663acc2b3ee90a9d8b308/node_modules/bower/lib/util/analytics.js:22:16) 
at Object.<anonymous> (/home/app/app/releases/277b5e33bb87229e434663acc2b3ee90a9d8b308/node_modules/bower/bin/bower:76:11) 
at Module._compile (module.js:456:26) 
at Object.Module._extensions..js (module.js:474:10) 
at Module.load (module.js:356:32) at Function.Module._load (module.js:312:12) 
at Function.Module.runMain (module.js:497:10) at startup (node.js:119:16)

This needs to be resolved by preventing even instantiating Insight if CI is set or --config.interactive=false
@sheerun sheerun added the bug label Apr 8, 2014
sheerun added a commit that referenced this issue Apr 12, 2014
@sheerun
Improve noninteractive loading performance 2x, fixes #1221
74d568b
@sheerun sheerun mentioned this issue Apr 12, 2014
Merged
sindresorhus added a commit that referenced this issue Apr 12, 2014
@sindresorhus
Merge pull request #1238 from bower/feature/performance
d59edd6 
Improve noninteractive loading performance 2x, fixes #1221
myabc added a commit to opf/openproject that referenced this issue Apr 28, 2014
@myabc
Bump Bower to latest (1.3.3)
58efd62 
This should address an issue affecting CI: bower/bower#1221
(see https://github.com/bower/bower/blob/master/CHANGELOG.md#133---2014-04-24)

https://www.openproject.org/work_packages/7196

Signed-off-by: Alex Coles <alex@alexbcoles.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve noninteractive loading performance 2x, fixes #1221 bower/bower
1 participant
@sheerun