Bower crashes for no reason from a bash script

[binarykitchen]

Hi there

In one of my git hooks I run an external bash script. And in that script we have bower install between the lines. Each time it crashes with the error below. When I run bower install manually, it works.

The crash is weird and does not say what's wrong. Hope you guys can fix this?

Thanks!
M

/opt/node-0.10.16/lib/node_modules/bower/node_modules/tmp/lib/tmp.js:261

  throw err;









^


TypeError: Arguments to path.join must be strings
    at path.js:360:15
    at Array.filter (native)
    at Object.exports.join (path.js:358:36)
    at rc (/opt/node-0.10.16/lib/node_modules/bower/node_modules/bower-config/lib/util/rc.js:28:19)
    at Config.load (/opt/node-0.10.16/lib/node_modules/bower/node_modules/bower-config/lib/Config.js:12:20)
    at Function.Config.read (/opt/node-0.10.16/lib/node_modules/bower/node_modules/bower-config/lib/Config.js:47:19)
    at Object.<anonymous> (/opt/node-0.10.16/lib/node_modules/bower/lib/config.js:3:38)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)

Deploy script ended on Wed Aug 28 2013 16:23:43 GMT+1200 (NZST) with exit code 7

[satazor]

It's crashing on https://github.com/bower/config/blob/master/lib/util/rc.js#L28 because apparently no HOME folder is set (via env variables). Anyway, it should not crash in that case anyway so I will protect that.

[satazor]

Fixed in https://github.com/bower/config/commit/6abd4e5f9b3f8f7f1722e0bc361c63bfe8667f87. Can you please uninstall bower and install it again with npm uninstall -g -f bower && npm install -g bower and report back?

[wibblymat]

We seem to have a few problems with assuming that HOME is set. Maybe we
should check at startup that it is set and that the path exists, just like
we check for git?
On 28 Aug 2013 08:23, "André Cruz" notifications@github.com wrote:

Fixed in bower/config@6abd4e5https://github.com/bower/config/commit/6abd4e5f9b3f8f7f1722e0bc361c63bfe8667f87.
Can you please uninstall bower and install it again with npm uninstall -g
-f bower && npm install -g bower and report back?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/826#issuecomment-23395780
.

[satazor]

@wibblymat we could do that, but we should not error out because even without HOME bower should work.

[wibblymat]

I was thinking that we would issue a warning to say that we couldn't
determine a HOME so we can't use your cache or bowerrc, something like
that. Stops users being surprised when things don't work the same as when
they just run it manually.
On 28 Aug 2013 08:38, "André Cruz" notifications@github.com wrote:

@wibblymat https://github.com/wibblymat we could do that, but we should
not error out because even without HOME bower should work.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/826#issuecomment-23396459
.

[satazor]

Yes I like that.

[binarykitchen]

You mentioned a missing HOME. So I fixed one line in that upstart service to this:

exec sudo -H -u <username> node <path to git hook server>

The -H forces to set a HOME directory and then Bower worked like a charm when deploying releases. I did not try @satazor's commit yet. Happy with the -H fix. But yes, a warning would be good.

[satazor]

Alright I will create a new issue for this.