Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix the Requirement Checker terminal #998

Merged
merged 2 commits into from
Dec 9, 2023

Conversation

theofidry
Copy link
Member

No description provided.

@theofidry
Copy link
Member Author

theofidry commented Dec 8, 2023

To try:

diff --ignore-all-space --side-by-side --suppress-common-lines $(ORIGINAL_TERMINAL) src/Terminal.php > $@ || true

(and use $(DIFF) instead. Otherwise the issue can be the TTY, as diff or other commands may behave differently with an interactive terminal (e.g. to allow scrolling).

because of || true) > the redirect happens after so if the terminal is a TTY the output might be different. By doing the || true after, even if the terminal is TTY diff will behave as if it was not.

@theofidry theofidry reopened this Dec 9, 2023
@theofidry theofidry merged commit 4025076 into box-project:main Dec 9, 2023
162 checks passed
@theofidry theofidry deleted the test/req-checker branch December 9, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant