fix(annotations): Fix annotations control shows if no permission

box · May 6, 2020 · b3ccf56 · b3ccf56
1 parent 1c8ac70
commit b3ccf56
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/src/lib/viewers/BaseViewer.js b/src/lib/viewers/BaseViewer.js
@@ -1051,7 +1051,11 @@ class BaseViewer extends EventEmitter {
      */
     areNewAnnotationsEnabled() {
         const { showAnnotationsControls, file } = this.options;
-        const { extension } = file || {};
+        const { permissions, extension } = file || {};
+
+        if (!this.hasAnnotationPermissions(permissions)) {
+            return false;
+        }
 
         // Disable new annotations for Excel and iWork formats
         if (EXCEL_EXTENSIONS.includes(extension) || IWORK_EXTENSIONS.includes(extension)) {

diff --git a/src/lib/viewers/__tests__/BaseViewer-test.js b/src/lib/viewers/__tests__/BaseViewer-test.js
@@ -1262,7 +1262,21 @@ describe('lib/viewers/BaseViewer', () => {
         });
     });
 
-    describe('areNewAnnotationsEnabled()', () => {
+    describe.only('areNewAnnotationsEnabled()', () => {
+        beforeEach(() => {
+            stubs.hasPermissions = sandbox.stub(base, 'hasAnnotationPermissions').returns(true);
+            base.options.file = {
+                permissions: {
+                    can_annotate: true,
+                },
+            };
+        });
+
+        it('should return false if the user cannot create/view annotations', () => {
+            stubs.hasPermissions.returns(false);
+            expect(base.areNewAnnotationsEnabled()).to.be.false;
+        });
+
         EXCEL_EXTENSIONS.concat(IWORK_EXTENSIONS).forEach(extension => {
             it(`should return false if the file is ${extension} format`, () => {
                 base.options.file.extension = extension;