Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Get response as text from axios #957

Merged
merged 1 commit into from
Mar 12, 2019

Conversation

ConradJChan
Copy link
Contributor

@ConradJChan ConradJChan commented Mar 12, 2019

For some reason, when specifying responseType: 'text' axios still returns the response data as parsed json, so adding a transformResponse option to get the text back for PlainTextViewer content

@boxcla
Copy link

boxcla commented Mar 12, 2019

Verified that @ConradJChan has signed the CLA. Thanks for the pull request!

let transformResponse;

if (options.responseType === 'text') {
transformResponse = api.transformTextResponse;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like passing undefined also works.

@@ -60,7 +62,13 @@ const api = {
* @return {Promise} - XHR promise
*/
xhr(url, options = {}) {
return axios(url, api.filterOptions(options))
let transformResponse;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does having this undefined affect any other response types?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should get filtered out on L70

@ConradJChan ConradJChan merged commit 68fa4d1 into box:master Mar 12, 2019
@ConradJChan ConradJChan deleted the fix-highlights branch March 12, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants