Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Get response as text from axios #957

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Fix: Get response as text from axios #957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/lib/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ const api = {
return response.data;
},

transformTextResponse: (data) => data,

/**
* Wrapper function for XHR post put and delete
*
Expand All @@ -60,7 +62,13 @@ const api = {
* @return {Promise} - XHR promise
*/
xhr(url, options = {}) {
return axios(url, api.filterOptions(options))
let transformResponse;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does having this undefined affect any other response types?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should get filtered out on L70


if (options.responseType === 'text') {
transformResponse = api.transformTextResponse;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like passing undefined also works.

}

return axios(url, api.filterOptions({ transformResponse, ...options }))
.then(api.parseResponse)
.catch(api.handleError);
},
Expand Down