fix: prevent printing via browser #1045
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when there is no download permission. This still does not prevent other ways to print/get data.
|
Verified that @priyajeet has signed the CLA. Thanks for the pull request! |
jstoffan
reviewed
Jul 19, 2019
| ${SELECTOR_BOX_PREVIEW}, | ||
| ${SELECTOR_BOX_PREVIEW_CONTAINER}, | ||
| ${SELECTOR_BOX_PREVIEW_CONTENT} { | ||
| display: none !important; |
There was a problem hiding this comment.
Could we include this rule in a class in the base stylesheet and add the class to the root element as needed?
ConradJChan
reviewed
Jul 19, 2019
| * @return {void} | ||
| */ | ||
| preventBrowserPrinting() { | ||
| const sheet = document.styleSheets[0]; |
There was a problem hiding this comment.
Could we create a style element and insert as the first stylesheet?
|
Closing for now, as I think this is partially addressed by #1076. Feel free to re-open if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when there is no download permission. This still does not prevent other ways to print/get data.