feat(archive): Add root folder #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @mxiao6 has signed the CLA. Thanks for the pull request! |
mickr
reviewed
Jan 11, 2020
mickr
previously approved these changes
Jan 13, 2020
|
Possible to do another patch release today so that this will go into the GA release? |
I'm waiting the designer for if 'Root Folder' text is ok. |
jstoffan
reviewed
Jan 13, 2020
jstoffan
previously approved these changes
Jan 13, 2020
jstoffan
previously approved these changes
Jan 13, 2020
jstoffan
approved these changes
Jan 14, 2020
| @@ -71,7 +71,7 @@ class ArchiveViewer extends BaseViewer { | |||
|
|
|||
| try { | |||
| /* global BoxArchive loaded from archive.js */ | |||
| this.archiveComponent = new BoxArchive(this.archiveEl, data); | |||
| this.archiveComponent = new BoxArchive(this.archiveEl, this.options.file.name, data); | |||
There was a problem hiding this comment.
Just to confirm: Are this.options.file and this.options.file.name always defined?
There was a problem hiding this comment.
Just to confirm: Are
this.options.fileandthis.options.file.namealways defined?
If file is not defined, the representations are not too, so the expected behavior is to throw the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.