chore(resin): Add annotations resin tags #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mxiao6
commented
Jun 29, 2020
•
mxiao6
commented
jstoffan
reviewed
Jun 29, 2020
| @@ -1099,6 +1099,7 @@ class DocBaseViewer extends BaseViewer { | |||
|
|
|||
| if (this.areNewAnnotationsEnabled() && this.hasAnnotationCreatePermission()) { | |||
| this.annotationControls.init({ | |||
| fileId: this.options.file.id, | |||
There was a problem hiding this comment.
Is it possible for this value to change after init has been called?
There was a problem hiding this comment.
If file id changes, the preview will be destroyed and re-init everything, right?
jstoffan
reviewed
Jun 29, 2020
jstoffan
reviewed
Jun 29, 2020
src/lib/AnnotationControls.ts
Outdated
| @@ -185,6 +186,12 @@ export default class AnnotationControls { | |||
| groupElement, | |||
| ); | |||
|
|
|||
| groupElement.setAttribute('data-resin-feature', 'annotations'); | |||
| regionButton.setAttribute('data-resin-target', 'highlightRegion'); | |||
| if (fileId) { | |||
There was a problem hiding this comment.
Why is this an optional parameter? What scenario would lead this value to be undefined/null? Is that scenario handled?
jstoffan
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.