feat(controls): Add core media settings control components #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoffan
force-pushed
the
controls-setting-1
branch
from
025ec82
to
c445d21
Compare
ConradJChan
reviewed
Mar 12, 2021
src/lib/viewers/controls/media/MediaSettingsControls/MediaSettingsControls.tsx
Outdated
Show resolved
Hide resolved
src/lib/viewers/controls/media/MediaSettingsControls/MediaSettingsContext.ts
Show resolved
Hide resolved
src/lib/viewers/controls/media/MediaSettingsControls/MediaSettingsMenu.tsx
Outdated
Show resolved
Hide resolved
src/lib/viewers/controls/media/MediaSettingsControls/MediaSettingsMenu.tsx
Outdated
Show resolved
Hide resolved
src/lib/viewers/controls/media/MediaSettingsControls/MediaSettingsMenu.tsx
Outdated
Show resolved
Hide resolved
src/lib/viewers/controls/media/MediaSettingsControls/MediaSettingsMenu.tsx
Show resolved
Hide resolved
src/lib/viewers/controls/media/MediaSettingsControls/MediaSettingsMenu.tsx
Outdated
Show resolved
Hide resolved
src/lib/viewers/controls/media/MediaSettingsControls/__tests__/MediaSettingsControls-test.tsx
Outdated
Show resolved
Hide resolved
src/lib/viewers/controls/media/MediaSettingsControls/__tests__/MediaSettingsFlyout-test.tsx
Show resolved
Hide resolved
ConradJChan
approved these changes
Mar 12, 2021
|
Thanks for the review, @ConradJChan! |
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've split the media settings controls code into multiple PRs to keep the size down; this is just the first. I've tested the full changeset on all our supported browsers with React 17. I plan to open two follow-up PRs after this is merged:
Big thanks to @mxiao6 for his work on the core design of the components.