Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(annotations tooltip): Close on click outside to avoid UI issues #1387

Merged
merged 1 commit into from May 21, 2021
Merged

feat(annotations tooltip): Close on click outside to avoid UI issues #1387

merged 1 commit into from May 21, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 21, 2021

No description provided.

@ghost ghost self-requested a review as a code owner May 21, 2021 20:49
shouldTarget={isEnabled}
showCloseButton
tetherElementClassName="bp-AnnotationsTooltipTether"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm: Is this change intentional? Is the increased z-index no longer needed?

Copy link
Author

@ghost ghost May 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jstoffan - Correct, we no longer need the z-index, because if we click on the share button which opens the modal that was causing the z-index issue the tooltip will now close so it's not a problem

shouldTarget={isEnabled}
showCloseButton
tetherElementClassName="bp-AnnotationsTooltipTether"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we no longer need this as the tooltip will close if the preview share modal is clicked

@ghost ghost added the ready-to-merge label May 21, 2021
@mergify mergify bot merged commit 9d76b1e into box:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant