New: Add pseudo fullscreen to mobile Safari #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pramodsum
approved these changes
Jul 27, 2017
JustinHoldstock
approved these changes
Jul 27, 2017
tonyjin
reviewed
Jul 28, 2017
src/lib/viewers/BaseViewer.js
Outdated
| @@ -361,6 +354,20 @@ class BaseViewer extends EventEmitter { | |||
| } | |||
|
|
|||
| /** | |||
| * Applies appropriate styles and resizes the document depending on fullscreen state | |||
| * @protected | |||
There was a problem hiding this comment.
Nit - space after description before @. We also stopped marking things as protected
| @@ -361,7 +361,7 @@ class DocBaseViewer extends BaseViewer { | |||
| const previousPageButtonEl = this.containerEl.querySelector('.bp-previous-page'); | |||
| const nextPageButtonEl = this.containerEl.querySelector('.bp-next-page'); | |||
|
|
|||
| // Safari disables keyboard input in fullscreen | |||
| // Safari disables keyboard input in fullscreen before Safari 10.1 | |||
There was a problem hiding this comment.
Can we detect this and re-enable page selector in Safari 10.1?
There was a problem hiding this comment.
I'll do that in a separate PR since it's not trivial to select 10.1 on iOS and Safari at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setting position: fixed