Fix: Emit scale does not always pass events #261
Conversation
| } | ||
| }; | ||
|
|
||
| base.addCommonListeners(); |
There was a problem hiding this comment.
Not sure this is actually checking any expectations. I'd just do something like
this.annotationPromise = {};
base.emit('load', ....);
expect(base.loadAnnotor).to.be.called;
etc. for w/e is called and check that scale is set if it exists in event.scale
There was a problem hiding this comment.
The expectation is that the annotations promise is called. done() is only resolved when the annotations promise is called. Unfortunately we cannot expect base.loadAnnotator to be called since events are async.
I've added a check to ensure that base.scale is set and that base.loadAnnotator is passed into the promise.then function.
There was a problem hiding this comment.
Oops you're right. Totally missed that! This works 👍
| } | ||
| }; | ||
|
|
||
| base.addCommonListeners(); |
There was a problem hiding this comment.
Oops you're right. Totally missed that! This works 👍
Thanks to @pramodsum for the catch.
Fancy destructure syntax was no good here.