Update: npm packages to latest versions #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypress
reviewed
Nov 8, 2017
| @@ -365,7 +365,7 @@ class DocBaseViewer extends BaseViewer { | |||
| * @return {void} | |||
| */ | |||
| setPage(pageNumber) { | |||
| if (pageNumber < 1 || pageNumber > this.pdfViewer.pagesCount) { | |||
| if (!pageNumber || pageNumber < 1 || pageNumber > this.pdfViewer.pagesCount) { | |||
| @@ -116,7 +111,7 @@ | |||
| "prettier": "prettier-eslint \"src/lib/**/*.js\" --print-width 120 --single-quote --tab-width 4 --write", | |||
| "prod": "BABEL_ENV=production NODE_ENV=production node --max_old_space_size=4096 ./node_modules/webpack/bin/webpack.js --progress --colors --config build/webpack.config.js", | |||
| "release": "yarn run clean && yarn run build-rb && yarn run lint && yarn run test && yarn run prod", | |||
| "test": "NODE_ENV=test ./node_modules/.bin/karma start build/karma.conf.js", | |||
| "test": "NODE_ENV=test node --max_old_space_size=4096 ./node_modules/.bin/karma start build/karma.conf.js", | |||
There was a problem hiding this comment.
Is there a way we can tell if we have a memory leak? Or is this just a reasonable amount of memory to run tests?
There was a problem hiding this comment.
This is a temporary solution while we look into ways to optimize the unit tests. We shouldn't be hitting this limit (especially after annotations has been removed). I'm going to go through the tests and verify that they're all being cleaned up properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages that still need to be updated