Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correctly revoke objectURL for print blob in office viewer #482

Merged
merged 3 commits into from
Nov 14, 2017
Merged

Fix: Correctly revoke objectURL for print blob in office viewer #482

merged 3 commits into from
Nov 14, 2017

Conversation

jeremypress
Copy link
Contributor

Original fix here: #444
feeling the pain of repeated code

@pramodsum
Copy link
Contributor

Is there any way we can consolidate this revoke logic amongst viewers so we won't run into an issue like this again?

@tonyjin
Copy link
Contributor

tonyjin commented Nov 13, 2017

@pramodsum: #62

We tabled that due to complications, but may be worth revisiting.

@jeremypress
Copy link
Contributor Author

I don't think it would be worth it to just abstract the printURL without doing the rest, which ended up being pretty messy the first time I tried.

@jeremypress jeremypress merged commit bc12c53 into box:master Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants