Chore: Add stage to run functional tests only on type 'cron' #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jeremypress has signed the CLA. Thanks for the pull request! |
jeremypress
commented
Dec 8, 2017
| before_script: | ||
| - python -m SimpleHTTPServer & | ||
| - sleep 2 | ||
| stages: |
There was a problem hiding this comment.
New travis syntax. Here we list the stages that we want our job to execute, and can pass in conditional logic on when to execute them
| - name: sauce-labs | ||
| if: type = cron | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
Of our list of "jobs", we list which stages we want to include, and their corresponding script. It make make more sense to break the functional test into their own job, but that's more of a semantics thing then a change in functionality.
pramodsum
approved these changes
Dec 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.