Event names into separate file #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @JustinHoldstock has signed the CLA. Thanks for the pull request! |
jeremypress
approved these changes
Jan 17, 2018
pramodsum
reviewed
Jan 17, 2018
src/lib/events.js
Outdated
| @@ -0,0 +1,13 @@ | |||
| // Events emitted by Viewers | |||
| // eslint-disable-next-line import/prefer-default-export | |||
| export const VIEWER_EVENTS = { | |||
There was a problem hiding this comment.
could we rename it to VIEWER_EVENT rather than VIEWER_EVENTS?
pramodsum
reviewed
Jan 17, 2018
src/lib/events.js
Outdated
| notificationShow: 'notificationshow', // Show notification modal. | ||
| notificationHide: 'notificationhide', // Hide notification modal. | ||
| mediaEndAutoplay: 'mediaendautoplay', // Media playback has completed, with autoplay enabled. | ||
| generic: 'viewerevent' // The generic default viewer event |
pramodsum
approved these changes
Jan 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves all viewer events into
events.jsto provide documentation for each event and reduce possibility of using the wrong event names.