Chore: Add util tests and fix file tests #702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 6, 2018 14:18
- Contact Us redirect to Box support page should only show up in the Box web application - Fix non-wrapping error text in IE11 - Consolidate download checks into util function - Move file-specific util method into file.js
Add Babel Rewire plugin so we can properly test `inBoxWebApp()` and fix `canDownload()` tests
|
Verified that @tonyjin has signed the CLA. Thanks for the pull request! |
tonyjin
commented
Mar 7, 2018
| [false, true, false, false, false], | ||
| [true, false, false, false, false], | ||
| [true, true, true, true, true], | ||
| ].forEach(([isDownloadable, isDownloadEnabled, havePermission, isBrowserSupported, expectedResult]) => { |
There was a problem hiding this comment.
I didn't have the [] here before wrapping the arguments at first, but the test still passed since an array for the first param and undefined for all of the others still passed the test...
tonyjin
commented
Mar 7, 2018
| */ | ||
| export function getHostname() { | ||
| return window.location.hostname || ''; | ||
| } |
There was a problem hiding this comment.
Now hostname is stub-able for tests
|
Huh, looks like Rewire may be causing a bunch of other issues with our tests... Will re-visit after #696 is merged. |
|
Closing in favor of #709 Babel rewire was causing issues with a lot of other tests. Essentially any other test that stubbed out something imported from file, util, or any other function that exported functions needed to be rewritten with Babel rewire. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Babel Rewire plugin so we can properly test
inBoxWebApp()and fixcanDownload()testsDepends on #696