Update: Add BoundedCache for Thumbnails Sidebar #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @ConradJChan has signed the CLA. Thanks for the pull request! |
jeremypress
approved these changes
Feb 7, 2019
| constructor(maxEntries) { | ||
| super(); | ||
|
|
||
| this.maxEntries = maxEntries || 500; |
There was a problem hiding this comment.
I guess this is more specific to the application of Thumbnail images, but it's basically arbitrary. I figure if the images are ~50KB 500 would be 25MB of cache which seemed like an ok starting point
| // If image is already in cache, then use it instead of waiting for | ||
| // the second render image pass | ||
| const cachedImage = this.thumbnailImageCache.get(itemIndex); | ||
| if (cachedImage && !cachedImage.inProgress) { |
There was a problem hiding this comment.
wouldn't we still want to use it even if it's in progress again?
There was a problem hiding this comment.
if It's in progress, that means there is no generated image yet so there's nothing to insert into the DOM at this point. We add a cache entry with inProgress as true to avoid multiple images being requested
ConradJChan
pushed a commit
to ConradJChan/box-content-preview
that referenced
this pull request
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.