Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add missing values in SignRequestSignerInputContentType and SignRequestStatus #907

Merged
merged 1 commit into from
Jul 18, 2023
Merged

feat: Add missing values in SignRequestSignerInputContentType and SignRequestStatus #907

merged 1 commit into from
Jul 18, 2023

Conversation

arjankowski
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

coverage: 88.724% (+0.007%) from 88.717% when pulling e01393e on aj/sdk_3050-sign-multidoc into 1efb295 on main.

@arjankowski
Copy link
Contributor Author

arjankowski commented Jul 17, 2023 •
edited
Loading

Since I found missing values in the enums SignRequestSignerInputContentType and SignRequestStatus, I added them along with the tests.

I've also fixed formatting in some files because it generated a compile level warning

mhagmajer
mhagmajer approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@mhagmajer mhagmajer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mhagmajer mhagmajer merged commit 56a8250 into main Jul 18, 2023
4 checks passed
@mhagmajer mhagmajer deleted the aj/sdk_3050-sign-multidoc branch July 18, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhagmajer mhagmajer mhagmajer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arjankowski @coveralls @mhagmajer