fix: Fixed upload when data are coming from a dynamic source #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build #3139
💛 - Coveralls |
lukaszsocha2
reviewed
Aug 3, 2023
| } | ||
|
|
||
| /** | ||
| * Returns content length. If the content length cannot be derermined |
lukaszsocha2
reviewed
Aug 3, 2023
| bufferedSink.write(buffer, 0, n); | ||
| totalWritten += n; | ||
| if (progressListener != null) { | ||
| progressListener.onProgressChanged(totalWritten, this.contentLength()); |
There was a problem hiding this comment.
What if contentLength() returns -1. Would progress listener work correctly ?
There was a problem hiding this comment.
I've added details here:
in short total size will be -1 but bytes written should be properly returned.
lukaszsocha2
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With OkHttp not really working with stream we have our own solution. But it can work with them as long as we tell it that content size if unknown.
This was the source of the problem in the #1183 where two threads started and one was feeding data to other. First was downloading a file second was uploading new version.
This should also address failing uploads when dealing with a stream which full size cannot be determined upfront (#1190 ).