Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add test for uploading file using stream #1258

Merged
merged 3 commits into from
Jul 15, 2024
Merged

test: Add test for uploading file using stream #1258

merged 3 commits into from
Jul 15, 2024

Conversation

lukaszsocha2
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jul 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3912

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.002%) to 72.44%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/MetadataQuery.java 1 92.59%
src/main/java/com/box/sdk/BoxFileUploadSession.java 1 64.67%
src/main/java/com/box/sdk/EventStream.java 1 86.46%
Totals Coverage Status
Change from base Build #3889: 0.002%
Covered Lines: 7683
Relevant Lines: 10606
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build #3903

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.002%) to 72.44%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/MetadataQuery.java 1 92.59%
src/main/java/com/box/sdk/BoxFileUploadSession.java 1 64.67%
src/main/java/com/box/sdk/EventStream.java 1 86.46%
Totals Coverage Status
Change from base Build #3889: 0.002%
Covered Lines: 7683
Relevant Lines: 10606
💛 - Coveralls

@lukaszsocha2 lukaszsocha2 changed the title test: support stream file upload test: Add test for uploading file using stream Jul 12, 2024
mwwoda
mwwoda approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@mwwoda mwwoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukaszsocha2 lukaszsocha2 merged commit cabe78f into main Jul 15, 2024
11 of 12 checks passed
@lukaszsocha2 lukaszsocha2 deleted the sdk-3898-support-stream-file-upload branch July 15, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwwoda mwwoda mwwoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukaszsocha2 @coveralls @mwwoda