fix: Update proxy-agent usage, drop support Node 12 (#865)

box · Nov 3, 2023 · e229d3f · e229d3f
1 parent 86255fd
commit e229d3f
Show file tree

Hide file tree

Showing 6 changed files with 57 additions and 95 deletions.
diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml
@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: ['12', '14', '16', '18', '20']
+        node: ['14', '16', '18', '20']
     name: Node ${{ matrix.node }}
     steps:
       - name: Checkout

diff --git a/README.md b/README.md
@@ -5,8 +5,8 @@
 Box Node.js SDK
 ===============
 
-[![Greenkeeper badge](https://badges.greenkeeper.io/box/box-node-sdk.svg)](https://greenkeeper.io/)
-![Platform](https://img.shields.io/badge/node-12--20-blue)
+[![Known Vulnerabilities](https://snyk.io/test/github/box/box-node-sdk/badge.svg)](https://snyk.io/test/github/box/box-node-sdk)
+![Platform](https://img.shields.io/badge/node-14--20-blue)
 [![Project Status](http://opensource.box.com/badges/active.svg)](http://opensource.box.com/badges)
 [![Coverage](https://coveralls.io/repos/github/box/box-node-sdk/badge.svg?branch=main)](https://coveralls.io/github/box/box-node-sdk?branch=main)
 
@@ -253,7 +253,7 @@ We highly recommend upgrading to the latest SDK major release at the earliest co
 
 | Version | Supported Environments | State     | First Release | EOL/Terminated |
 |---------|------------------------|-----------|---------------|----------------|
-| 3       | Node.js >= 12 and <= 20| Supported | 23 May 2023   | TBD            |
+| 3       | Node.js >= 14 and <= 20| Supported | 23 May 2023   | TBD            |
 | 2       | Node.js >= 8 and <= 14 | Maintained | 29 Sep 2021   | 23 Jul 2023    |
 | 1       |                        | EOL       | 28 Mar 2019   | 29 Sep 2021    |
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -18,7 +18,7 @@
     "sdk"
   ],
   "engines": {
-    "node": ">= 12.0.0"
+    "node": ">= 14.0.0"
   },
   "main": "./lib/box-node-sdk.js",
   "scripts": {
@@ -43,7 +43,7 @@
     "jsonwebtoken": "^9.0.2",
     "merge-options": "^1.0.1",
     "promise-queue": "^2.2.3",
-    "proxy-agent": "^6.3.0",
+    "proxy-agent": "^6.3.1",
     "url-template": "^2.0.8",
     "uuid": "^9.0.0"
   },

diff --git a/src/util/config.ts b/src/util/config.ts
@@ -199,7 +199,7 @@ function updateRequestAgent(
 		Required<Pick<UserConfigurationOptions, 'proxy'>>
 ) {
 	if (params.proxy.url) {
-		const ProxyAgent = require('proxy-agent');
+		const ProxyAgent = require('proxy-agent').ProxyAgent;
 		params.request.agentClass = ProxyAgent;
 		params.request.agentOptions = Object.assign(
 			{},

diff --git a/tests/integration_test/__tests__/sign-request.test.js b/tests/integration_test/__tests__/sign-request.test.js
@@ -91,4 +91,4 @@ test('test sign request', async() => {
 		await file1.dispose();
 		await file2.dispose();
 	}
-});
+}, 120000);