Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insensitive language: replace whitelist with allowlist #625

Merged
merged 9 commits into from
May 13, 2021

Conversation

mhagmajer
Copy link
Contributor

@mhagmajer mhagmajer commented May 10, 2021

This replaces uses of *whitelist* with *allowlist* across file names and contents.

Some of the code is related to the actually endpoint include the insensitive word:

Note for reviewer:

This PR includes whitespace changes (trailing newlines removed). It's useful to turn on this setting when reviewing:
Screenshot 2021-05-10 at 18 02 32

@sujaygarlanka
Copy link
Contributor

We probably want to keep collaboration_whitelist.ts alongside collaboration_allowlist.ts, but just deprecate it. This will allow customers to take advantage of updates to our SDK and not make this a breaking change. May make sense to keep the documentation and tests along with it, but deprecate them as well. I did something like this here box/box-java-sdk#889. Thoughts?

@mhagmajer
Copy link
Contributor Author

We probably want to keep collaboration_whitelist.ts alongside collaboration_allowlist.ts, but just deprecate it. This will allow customers to take advantage of updates to our SDK and not make this a breaking change. May make sense to keep the documentation and tests along with it, but deprecate them as well. I did something like this here box/box-java-sdk#889. Thoughts?

Good idea! I've added src/managers/collaboration-whitelist.ts that exports the moved file in case anyone was importing this file directly. For other potentially breaking changes I've made sure to keep the original names to such us BoxClient.collaborationWhitelist and CollaborationAllowlist.getWhitelistedDomain and others.

CHANGELOG.md Outdated Show resolved Hide resolved
sujaygarlanka
sujaygarlanka previously approved these changes May 13, 2021
@mhagmajer mhagmajer merged commit a52170e into main May 13, 2021
@mhagmajer mhagmajer deleted the insensitive-whitelist branch May 13, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants