-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insensitive language: replace whitelist with allowlist #625
Conversation
We probably want to keep collaboration_whitelist.ts alongside collaboration_allowlist.ts, but just deprecate it. This will allow customers to take advantage of updates to our SDK and not make this a breaking change. May make sense to keep the documentation and tests along with it, but deprecate them as well. I did something like this here box/box-java-sdk#889. Thoughts? |
Good idea! I've added |
This replaces uses of
*whitelist*
with*allowlist*
across file names and contents.Some of the code is related to the actually endpoint include the insensitive word:
Note for reviewer:
This PR includes whitespace changes (trailing newlines removed). It's useful to turn on this setting when reviewing: