Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed query to a required field. #341

Closed
wants to merge 2 commits into from
Closed

Conversation

mitquinn
Copy link
Contributor

@mitquinn mitquinn commented Aug 9, 2023

Description

Query is a required field in the search API.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own changes
  • I have run yarn lint to make sure my changes pass all linters
  • I have pulled the latest changes from the upstream developer branch

Contribution guidelines

For contribution guidelines, styleguide, and other helpful information please
see the CONTRIBUTING.md file in the root of this project.

@mitquinn mitquinn changed the title changed query to a required field. fix: changed query to a required field. Aug 9, 2023
@mitquinn
Copy link
Contributor Author

Is the build failure because I forgot to do something or the build broken?

@bszwarc
Copy link
Collaborator

bszwarc commented Feb 20, 2024

Hi @mitquinn no, it's ok - we have moved the specification to the api service, and will fix the issue there.

@bszwarc
Copy link
Collaborator

bszwarc commented Jun 3, 2024

Closing for now - the field is not always required. As mentioned in the docs:
This field is required unless the mdfilters parameter is defined.

@bszwarc bszwarc closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants