-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): upgrade webpack and babel #3482
Conversation
Upgrade webpack, babel-loader, webpack-cli, and other babel packages Remove legacy openssl options during build
package.json
Outdated
"webpack-bundle-analyzer": "^3.6.0", | ||
"webpack-cli": "^3.3.10", | ||
"webpack-cli": "^4.9.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This upgrade is required due to receiving the error in webpack/webpack-cli#3005, after upgrading webpack and babel-loader
There are higher versions available, but I decided to use the lowest version which includes the fix to avoid any issues. https://github.com/webpack/webpack-cli/releases/tag/webpack-cli%404.9.1
If we want to upgrade more, I think we should do it in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and updated to latest in this PR
@@ -34,12 +34,6 @@ be.activitySidebarFilter.status.tasks = Tasks | |||
be.add = Add | |||
# Text to display when app is disabled by applied access policy | |||
be.additionalTab.blockedByShieldAccessPolicy = Use of this app is blocked due to a security policy. | |||
# Error message when an annotation deletion fails |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know why this file was updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It always seems to be updated whenever I run yarn build
. I can leave it out if you'd like, since I don't have a good idea of when we include changes from build vs not. When do we want to include changes vs not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these types of changes should be included when we delete the reference in the code. You can still see the translation used in the code here
box-ui-elements/src/elements/content-sidebar/activity-feed/annotation-thread/errors.js
Line 16 in d40456c
[ERROR_CODE_DELETE_ANNOTATION]: messages.errorDeleteAnnotation, |
replace proposals upgrade webpack-cli to latest
Pin @types/react to resolve mismatches between different versions
WIP - other build failures, see circleci
Upgrade webpack, babel-loader, webpack-cli, and other babel packages
Remove legacy openssl options during build
Purposefully did not remove proposal plugins or unused babel packages - should do in another PR.
To test this PR, make sure you remove node_modules and your existing yarn.lock, and run a fresh
yarn install
. Direct upgrades caused errors (not just warnings).There are currently warnings about css ordering, e.g.
These errors began after upgrading webpack, babel, and webpack-cli. In other words, these were not triggered or resolved by the various css loader upgrades. There's an informative thread at facebook/create-react-app#5372 which suggests that we could have ambiguous css imports. However, the root cause is unclear, as is any proof of actual impact.