Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add id and type field to shared-links:create response #427

Merged
merged 5 commits into from
Nov 10, 2022

Conversation

congminh1254
Copy link
Member

Closes: SDK-2713

@congminh1254 congminh1254 marked this pull request as draft November 9, 2022 09:46
@congminh1254 congminh1254 marked this pull request as ready for review November 9, 2022 11:33
Copy link
Contributor

@mhagmajer mhagmajer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI doesn't pass - please fix the version bump of box-node-sdk

@arjankowski arjankowski force-pushed the SDK-2713-add-type-and-id-fields-shared-link branch from 55ea9e1 to cce68d4 Compare November 10, 2022 14:25
Copy link
Contributor

@arjankowski arjankowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member Author

@congminh1254 congminh1254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock.json updated.

@congminh1254 congminh1254 dismissed mhagmajer’s stale review November 10, 2022 14:41

package-lock.json updated and now CI passed. Thankyou Marcin

@congminh1254 congminh1254 merged commit 5ea4cb8 into main Nov 10, 2022
@congminh1254 congminh1254 deleted the SDK-2713-add-type-and-id-fields-shared-link branch November 10, 2022 14:42
congminh1254 added a commit that referenced this pull request Jan 31, 2024
* feat: Add `id` and `type` field  to shared-links:create response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants