Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New fields in retention-policy and retention-policy-assignment #466

Merged
merged 3 commits into from
Apr 24, 2023
Merged

feat: New fields in retention-policy and retention-policy-assignment #466

merged 3 commits into from
Apr 24, 2023

Conversation

congminh1254
Copy link
Member

Closes: SDK-2844

@coveralls
Copy link

coveralls commented Apr 19, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4784628408

  • 24 of 25 (96.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 86.13%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commands/retention-policies/assign.js 14 15 93.33%
Files with Coverage Reduction New Missed Lines %
src/commands/files/zip.js 1 79.25%
Totals Coverage Status
Change from base Build 4470671577: -0.01%
Covered Lines: 3999
Relevant Lines: 4497
💛 - Coveralls

arjankowski
arjankowski reviewed Apr 21, 2023
View reviewed changes
src/commands/retention-policies/assign.js Outdated Show resolved Hide resolved
src/commands/retention-policies/assign.js Outdated Show resolved Hide resolved
src/commands/retention-policies/assign.js Outdated Show resolved Hide resolved
src/commands/retention-policies/create.js Outdated Show resolved Hide resolved
src/commands/retention-policies/create.js Show resolved Hide resolved
src/commands/retention-policies/assign.js Outdated Show resolved Hide resolved
src/commands/retention-policies/create.js Outdated Show resolved Hide resolved
arjankowski
arjankowski approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@arjankowski arjankowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@congminh1254 congminh1254 merged commit f960e59 into main Apr 24, 2023
@congminh1254 congminh1254 deleted the sdk-1844-update-retention-policy branch April 24, 2023 11:19
congminh1254 added a commit that referenced this pull request Jan 31, 2024
@congminh1254
feat: New fields in retention-policy and `retention-policy-assignme…
0fa4430 
…nt` (#466)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjankowski arjankowski arjankowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congminh1254 @coveralls @arjankowski