Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: copy to system clipboard from selected message #206

Closed
kiil opened this issue Nov 22, 2022 · 6 comments · Fixed by #210
Closed

Feature request: copy to system clipboard from selected message #206

kiil opened this issue Nov 22, 2022 · 6 comments · Fixed by #210

Comments

@kiil
Copy link

kiil commented Nov 22, 2022

Hi,

I often use the 'note to self' in Signal to send quick "on the road" notes from my mobile, and then later open them in front of my computer at home and add them to my documents.

Currently I believe there is no way to copy from a selected message in gurk to the system clipboard.

Is that a feature you would consider implementing?

Thanks for a nice client :)

@boxdot
Copy link
Owner

boxdot commented Nov 22, 2022

We have already a way to select a mesage with Alt+Up/Down. On Enter, if there is a link in the message, we open the link in the default browser. Now, we need another shortcut for copy the contents into the clipboard. Any ideas?

Unfortunately, clicking on the mesage for selecting it is not yet implemented. This might be also useful for this feature.

@kiil
Copy link
Author

kiil commented Nov 22, 2022

Now, we need another shortcut for copy the contents into the clipboard. Any ideas?

If possible, ctrl+enter

clicking on the mesage for selecting it is not yet implemented

It is already possible to select the message with the scroll wheel on the mouse 👍

@boxdot
Copy link
Owner

boxdot commented Dec 1, 2022

After checking out several clipboard crates, it looks like arboard is the best (other have conflicting requirements on X11 and Wayland, and sometimes need a window). However, CTRL + Enter does not work in terminals. So we need to come up with a different binding.

@kiil
Copy link
Author

kiil commented Dec 8, 2022

Thanks for investigating this :)

However, CTRL + Enter does not work in terminals. So we need to come up with a different binding.

How about ctrl-y for yank?

@boxdot
Copy link
Owner

boxdot commented Jan 26, 2023

Implemented for text messages with alt+y

boxdot added a commit that referenced this issue Jan 26, 2023
Copy shortcut `alt+y` (y stands for yank).

Also add shortcuts `alt+j/k` for selecting a message.

Closes #206
@kiil
Copy link
Author

kiil commented Jan 28, 2023

Thanks for this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants