-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alt+Enter newline shortcut #3
Conversation
Thank you! I had the same implementation but it does not work: crossterm-rs/crossterm#400. off-topic: If you have the line number where it panics, I might be able to fix it. |
I'll create a seperate issue about the panic. edit: and the sequence is supported edit 2: ah, the panic mentioned earlier is solved at #7 |
Sounds good! |
588a4da
to
a7ac6ad
Compare
Ok, I write very little rust but hopefully nothing looks off. The solution is a little janky, crossterm reads Alt+Enter as |
No worries. :) I appreciate the contribution a lot.
I like the factored out function. I was thinking that now, in the current implementation, we send |
I'm not familiar enough with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Private life got me, new job, etc... ☔ I am really sorry for being not responsive.
in most messaging apps, shift+enter enters a newline character. this pr adds that behavior.
currently i'm unable to test if this behaves as intended because running gurk panics for me