Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade libsignal-client 0.51.1 -> 0.56.1 #314

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

gferon
Copy link
Collaborator

@gferon gferon commented Sep 24, 2024

Not tested yet (I had openssl issues when doing cargo run on Fedora 40).

Fixes #313

@Alveel
Copy link

Alveel commented Oct 7, 2024

Installed with cargo install --git https://github.com/boxdot/gurk-rs --branch bump-presage-09-24 gurk.

It kinda works, though I had to restart gurk after linking for conversations/contacts to show.

@tealeg
Copy link

tealeg commented Oct 12, 2024

Also had to restart, and it seems to crash sometimes when receiving messages.

@gferon
Copy link
Collaborator Author

gferon commented Oct 12, 2024

Also had to restart, and it seems to crash sometimes when receiving messages.

Interesting. Could you please share the reason for the crash if you see an error message on the log file?

@tealeg
Copy link

tealeg commented Oct 13, 2024

@gferon the panic line is:

2024-10-13T21:23:39.089624Z ERROR panic: thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error { kind: Uncategorized, message: "no current exe available (short)" }': /home/tealeg/.cargo/registry/src/index.crates.io-6f17d22bba15001f/notify-rust-4.11.3/src/notification.rs:24    

@JohnnyZig
Copy link

This PR resolves my relinking issue, but now there is an error when I sent something:

[Could no send: store error: JSON error: missing field `expire_timer_version` at line 1 column 285]

Messages are sent but red error message is shown after each my message. My messages are still available after reset (they are stored in local database).

@JohnnyZig
Copy link

> [Could no send: store error: JSON error: missing field `expire_timer_version` at line 1 column 285]

And now it works without errors. I didn't changed anything. It wasn't worked after multiple tries and gurk restarts and after I posted here it started working 🤨

@boxdot boxdot marked this pull request as ready for review October 17, 2024 16:27
@boxdot boxdot changed the title Bump presage (fixes linking once again) upgrade libsignal-client 0.51.1 -> 0.56.1 Oct 17, 2024
@boxdot boxdot merged commit c1d06f3 into master Oct 17, 2024
16 checks passed
@boxdot boxdot deleted the bump-presage-09-24 branch October 17, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to link device - Unexpected response: HTTP 409
5 participants