This repository has been archived by the owner on May 22, 2018. It is now read-only.
Support moving all Homebrew configurations to $HOMEBREW_ROOT/etc/boxen
#855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following an upgrade to git 2.14.1 I was getting the following error:
```
[Librarian] Git: /usr/bin/git
error: unknown option `silent'
usage: git version [<options>]
--build-options also print build options
```
Digging into this I found voxpupuli/librarian-puppet#52 which shows a
fix by including the latest `librarianp` gem. This fixes the issue for
me however more digging into the architecture of `librarian-puppet` will
be required to understand this issue better.
Updates `script/nuke` to account for moving Homebrew's package configuration files outside of `/opt/boxen`. See boxen/puppet-boxen#146
jacobbednarz
force-pushed
the
nuke-etc-boxen
branch
from
7d8f39c to
1c04307
Compare
jacobbednarz
commented
Sep 26, 2017
| github "foreman", "1.2.0" | ||
| github "gcc", "3.0.2" | ||
| # mod "gcc", "0.0.1", :git => "https://github.com/boxen/puppet-gcc.git", :ref => "abc7639" |
There was a problem hiding this comment.
yep, this is gonna stay commented out until i can see if this actually breaks anything
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in boxen/boxen#214, this is the move to get all core packages and Boxen itself, to support putting the Homebrew packages under
$HOMEBREW_ROOT/etc/boxeninstead of/opt/boxen/configdue to some restrictions in upstream Homebrew.In this PR, we:
librarian-puppet's issues with newer Git and the--silentflag.puppet-boxen(Move the Boxen package configuration to/etcpuppet-boxen#146)puppet-dnsmasq(Update string replacement for file path puppet-dnsmasq#22)puppet-hub(Fix SHA for brew puppet-hub#20)puppet-nginx(Use#{etc}/boxenfor configuration directory puppet-nginx#52)puppet-ruby(Use a more recentruby-buildversion puppet-ruby#156)