This repository has been archived by the owner on Dec 2, 2020. It is now read-only.
if DYLD_FALLBACK_LIBRARY_PATH is empty, use default from man dyld
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Encountered a similar issue with 1.7.12 and 1.7.13, filed issue upstream at jruby/jruby#1830 |
| @@ -3,6 +3,10 @@ | |||
| # Invoke java with the $DYLD_LIBRARY_PATH set with the homebrew lib dir. | |||
| # This allows java to load native libraries installed via homebrew. | |||
|
|
|||
| if [ -z "$DYLD_FALLBACK_LIBRARY_PATH" ]; then | |||
| export DYLD_FALLBACK_LIBRARY_PATH="$HOME/lib:/usr/local/lib:/lib:/usr/lib" | |||
There was a problem hiding this comment.
Shouldn't need to export here
|
Sorry for the long delay on this. It looks fine except for the small change I noted about not needing to |
|
@dgoodlad doh! good catch. consider it removed. |
dgoodlad
added a commit
that referenced
this pull request
Aug 12, 2014
Fix blank DYLD_FALLBACK_LIBRARY_PATH behavior
|
Released in 1.6.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes #23
When
$DYLD_FALLBACK_LIBRARY_PATHis empty, the default path is used internally. Fromman dyldBy always appending homebrew's lib path to
DYLD_FALLBACK_LIBRARY_PATHwe end up breaking compatibility between java's ability to correctly reference the default paths for C libs, which breaks, among other things, parts ofjruby.Further Reading:
http://stackoverflow.com/questions/3146274/is-it-ok-to-use-dyld-library-path-on-mac-os-x-and-whats-the-dynamic-library-s#comment21758755_3172515
Homebrew/legacy-homebrew#13463