#46 Prevent ProcessInfo.update to overflow DB #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Skrattoune
commented
Jan 27, 2022
|
Your code looks a little bit "unformatted"... I will take your changes into a new PR... |
jedie
pushed a commit
that referenced
this pull request
Jan 28, 2022
Don't create a new TaskProgressModel instances for every `ProcessInfo.update()` call and increment a existing TaskProgressModel instances. So we will not flood the database ;) Based on #67
|
closed in favor of #68 ;) |
jedie
pushed a commit
that referenced
this pull request
Jan 28, 2022
Don't create a new TaskProgressModel instances for every `ProcessInfo.update()` call and increment a existing TaskProgressModel instances. So we will not flood the database ;) Based on #67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the PR fixing issue #46 that has been running in prod since August 2021 without any issue
Temporary fix while we wait for PR #58 to be ready and availlable