SF4 support #7
Open
SF4 support #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks for this PR :) The changes look good to me, but unfortunately I can't merge them until the tests pass. If anyone has time to look at making these tests pass, that would be great - I may be able to look at this myself soon, but not for a while. Happy to leave this PR open until that point though. Thanks for contributing! |
|
++ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified in Readme, there are some failing tests relating to the version of Guzzle being used, however this is being used in production and might form a useful basis for updating this library to include Symfony 4 support.
Thanks for the bundle :)