Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coerce trustServerCertificate to boolean #3087

Merged

Conversation

cwisdo
Copy link
Contributor

@cwisdo cwisdo commented Aug 28, 2024

What does this PR do?

Coerces trustServerCertificate in MSSQL database connection configuration to a boolean value as required by the downstream library.

Fixes #3086

Type of change

  • [X ] Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Existing unit tests

Checklist:

  • [X ] My code follows the style guidelines of this project
  • [X ] I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@deepakprabhakara
Copy link
Member

Thank you @cwisdo

Copy link
Member

@deepakprabhakara deepakprabhakara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwisdo Could you please run npm run format and check in the formatting changes.

@deepakprabhakara deepakprabhakara merged commit 3d02ee7 into boxyhq:main Aug 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSSQL connection with trustServerCertificate config fails to set value as boolean
2 participants