fix: add _id to upserted document

boycce · Jun 13, 2022 · a78512f · a78512f
1 parent b7039ae
commit a78512f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/model-crud.js b/lib/model-crud.js
@@ -255,7 +255,11 @@ module.exports = {
       // Update
       let update = await this['_' + type](opts.query, operators, util.omit(opts, this._queryOptions))
       if (type == 'findOneAndUpdate') response = update
-      else if (update.n) response = Object.assign(Object.create({ _output: update }), operators['$set']||{})
+      else if (update.n) response = Object.assign(
+        Object.create({ _output: update }),
+        operators['$set'] || {},
+        (update.upserted||[])[0] ? { _id: update.upserted[0]._id } : {},
+      )
 
       // Hook: afterUpdate (doesn't have access to validated data)
       if (response) await util.runSeries(this.afterUpdate.map(f => f.bind(opts, response)))

diff --git a/test/crud.js b/test/crud.js
@@ -201,6 +201,15 @@ module.exports = function(monastery, opendb) {
         name: 'Martin Luther3'
       }
     ])
+
+    // Upsert
+    let newId = db.id()
+    await expect(user.update({ query: newId, data: { name: 'Martin Luther3' }, upsert: true }))
+      .resolves.toEqual({ _id: newId, name: 'Martin Luther3' }) // inserted
+
+    await expect(user.update({ query: inserted._id, data: { name: 'Martin Luther4' }, upsert: true }))
+      .resolves.toEqual({ name: 'Martin Luther4' }) // updated
+
     db.close()
   })