Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not add a '~' when filename is not truncated #413

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

elindsey
Copy link
Contributor

@elindsey elindsey commented Nov 3, 2023

This fixes an off-by-one when the filename length exactly matches our size limit. As an example, today if the filename size limit is one character and the filename is named "a", it will be incorrectly formatted as "~a" despite no truncation occuring.

This fixes an off-by-one when the filename length exactly matches our
size limit. As an example, today if the filename size limit is one
character and the filename is named "a", it will be incorrectly
formatted as "~a" despite no truncation occuring.
@boyter
Copy link
Owner

boyter commented Nov 3, 2023

Nice pickup. I vaguely remember thinking this could be an issue when I wrote it but was doing other stuff and the time and it slipped my mind.

@boyter boyter merged commit 39672f9 into boyter:master Nov 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants