feat: support --exclude-content #509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is no more needed since 507 has been resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #507.
Support the "--exclude-content" option.
The reason why I put file content filtering in scc instead of gocodewalker is that we need to read the file contents first, and scc already did it, so only a small amount of code needs to be modified to implement the "exclude-content". And I put the filter in
fileProcessorWorker()because that makes it run in different goroutines in parallel.When we set "--exclude-content", the performance could get about 20% downgrade because we need to check files contents line by line:
There's no performance impact when not adding the "--exclude-content" option.