Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean field with feel required breaks the editor #70

Closed
marstamm opened this issue Feb 28, 2024 · 0 comments · Fixed by #73
Closed

Boolean field with feel required breaks the editor #70

marstamm opened this issue Feb 28, 2024 · 0 comments · Fixed by #73
Assignees
Labels
bug Something isn't working

Comments

@marstamm
Copy link
Collaborator

Describe the Bug

Adding the property

      {
        "label": "Demo",
        "value": false,
        "type": "Boolean",
        "feel": "required",
        "binding": {
          "type": "zeebe:input",
          "name": "foo"
        }
      }

will break the feel editor

Steps to Reproduce

  1. add the property to template
  2. apply template
  3. Try to edit field. It is broken

Expected Behavior

The FEEL editor shows =false and is editable

Additional info

Reported here: camunda/camunda-modeler#4154 (comment)
related to camunda/camunda-modeler#3622

Environment

  • Host (Browser/Node version), if applicable: [e.g. MS Edge 18, Chrome 69, Node 10 LTS]
  • OS: [e.g. Windows 7]
  • Library version: [e.g. 2.0.0]
@marstamm marstamm added bug Something isn't working ready Ready to be worked on labels Feb 28, 2024
@marstamm marstamm self-assigned this Feb 28, 2024
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Feb 29, 2024
marstamm added a commit that referenced this issue Feb 29, 2024
marstamm added a commit that referenced this issue Feb 29, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending in progress Currently worked on and removed in progress Currently worked on needs review Review pending labels Feb 29, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant