Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing a FEEL expression [0] reports misleading message #1078

Closed
1 task
nikku opened this issue Sep 20, 2024 · 2 comments
Closed
1 task

Accessing a FEEL expression [0] reports misleading message #1078

nikku opened this issue Sep 20, 2024 · 2 comments
Labels
bug Something isn't working ux

Comments

@nikku
Copy link
Member

nikku commented Sep 20, 2024

Describe the Bug

I'm trying out the new validation for FEEL expression [0] access. Whenever I write a FEEL expression with a [0] part the editor reports "unparseable FEEL expression":

capture JrKQ4I_optimized

Steps to Reproduce

  1. Create any FEEL expression, i.e. ServiceTask => Retries of the form = friends[0]
  2. See editor indicates expression is unparseable

Expected Behavior

  • The expression shows the issue, but is not marked as unparseable, because that is not correct, factually

Environment

  • Host (Browser/Node version), if applicable: Chrome 128
  • OS: Linux
  • Library version: v5.24.0
@nikku nikku added bug Something isn't working ux labels Sep 20, 2024
@nikku
Copy link
Member Author

nikku commented Sep 20, 2024

I'm looking into this, and see if there is a quick fix available. As of today the properties panel always calls onError, no matter the FEEL validation returned.

https://github.com/bpmn-io/properties-panel/blob/5aa01eee0767b640c14dd153af4d0214b859d111/src/components/entries/FEEL/Feel.js#L135

@nikku
Copy link
Member Author

nikku commented Sep 20, 2024

Fixed in two ways:

@nikku nikku added the fixed upstream Requires integration of upstream change label Sep 20, 2024
@nikku nikku closed this as completed in f9e1de2 Sep 20, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the fixed upstream Requires integration of upstream change label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ux
Projects
None yet
Development

No branches or pull requests

1 participant