Integrate first-item FEEL validation gracefully, as a warning
#381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: turn `first-item` validation into warning
Closed
1 task
barmac
reviewed
Sep 20, 2024
| @@ -130,14 +130,15 @@ function FeelTextfieldComponent(props) { | |||
| } | |||
| }; | |||
|
|
|||
| const handleLint = useStaticCallback(lint => { | |||
| const handleLint = useStaticCallback((lint = []) => { | |||
barmac
reviewed
Sep 20, 2024
|
|
||
| if (!(lint && lint.length)) { | ||
| const syntaxError = lint.some(report => report.type === 'Syntax Error'); |
barmac
approved these changes
Sep 20, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This ensures that
first-itemis not indicated as a hard error, but a warning. It also preventsfirst-itemmatches, along with any non-syntax errors, from showing off as aUnparseable FEEL expressionsyntax error.Try out via
Related to bpmn-io/bpmn-js-properties-panel#1078
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}