Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support intermediate message catch event templates #890

Closed
19 tasks done
Tracked by #3403
barmac opened this issue Mar 15, 2023 · 5 comments · Fixed by #906
Closed
19 tasks done
Tracked by #3403

Support intermediate message catch event templates #890

barmac opened this issue Mar 15, 2023 · 5 comments · Fixed by #906

Comments

@barmac
Copy link
Member

barmac commented Mar 15, 2023

What should we do?

In order to accomplish camunda/camunda-modeler#3403, we need to implement proper support in the element templates infrastructure:

  • Create event with message event definition from template
  • Replace already existing event definition when template is applied
  • Support bpmn:Message bindings:
    • property
    • zeebe:subscription
    • as unconditional properties
    • with conditions
  • Generate unique message name via generatedValue: 'uuid'
    • apply template
    • create from template
  • Hide templated message from messages list
  • When template is removed, remove message altogether
  • Apply should create a new message instead of reusing the referenced one
  • Copy and paste in the same diagram should create a new message
  • Replace with standard should remove the message
  • Handle template change (old and new template specified)
  • Remove message when element is removed
  • Message select should stay on top of the group
  • (optional) Modeling#updateModdleProperties does not add label for events name modification bpmn-js#1872

Why should we do it?

Related to camunda/camunda-modeler#3403

@barmac
Copy link
Member Author

barmac commented Mar 31, 2023

In the current state, we don't set $parent on message. I will look into this in spare time.

@barmac
Copy link
Member Author

barmac commented Mar 31, 2023

I will implement a fix for bpmn-io/bpmn-js#1872 as this is an annoying blocker for external label elements.

@barmac
Copy link
Member Author

barmac commented Apr 13, 2023

I implemented unlink and removal. At the moment, copy and paste does not work properly as we reuse the message unintentionally. I should build a prototype for this tomorrow.

@barmac
Copy link
Member Author

barmac commented Apr 14, 2023

What is still missing is "Remove message when the shape is removed" 🤡

barmac added a commit that referenced this issue Apr 25, 2023
barmac added a commit that referenced this issue Apr 25, 2023
barmac added a commit that referenced this issue Apr 25, 2023
barmac added a commit that referenced this issue Apr 27, 2023
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Apr 27, 2023
barmac added a commit that referenced this issue Apr 28, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 28, 2023
@barmac
Copy link
Member Author

barmac commented Apr 28, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant