Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Version tag field #1063

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Add Version tag field #1063

merged 5 commits into from
Aug 26, 2024

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Jul 10, 2024

Proposed Changes

  • adds Version tag field to processes

image

  • adds Version tag field to resources linked through version tag option

image

  • adjusts the Binding type tooltip

image

Requires camunda/zeebe-bpmn-moddle#65
Requires camunda/camunda-bpmn-js-behaviors#80

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jul 10, 2024
@philippfromme
Copy link
Contributor Author

We probably want to add a link to the (not yet existing) documentation to the tooltip and also rephrase the tooltip itself. @crobbins215 @lmbateman

@philippfromme philippfromme force-pushed the version-tag branch 2 times, most recently from b55bfe2 to 842576c Compare July 11, 2024 11:45
@philippfromme philippfromme added the ready Ready to be worked on label Jul 23, 2024 — with bpmn-io-tasks
@philippfromme philippfromme removed the in progress Currently worked on label Jul 23, 2024
@philippfromme philippfromme force-pushed the version-tag branch 3 times, most recently from d7f44af to 7475229 Compare August 23, 2024 13:15
philippfromme added a commit to camunda/camunda-bpmn-js-behaviors that referenced this pull request Aug 23, 2024
@philippfromme
Copy link
Contributor Author

This pull request depends on camunda/camunda-bpmn-js-behaviors#80 being integrated first.

philippfromme added a commit to camunda/camunda-bpmn-js-behaviors that referenced this pull request Aug 26, 2024
@philippfromme philippfromme marked this pull request as ready for review August 26, 2024 09:41
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed ready Ready to be worked on labels Aug 26, 2024
@philippfromme
Copy link
Contributor Author

Ready for review.

@nikku
Copy link
Member

nikku commented Aug 26, 2024

Quick clarficiation: Is versionTag provided via linking static only? I was under the impression we'd support dynamically computed tags:

image

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Ready to be merged, if static version tag is what we implemented (#1063 (comment)), pending confirmation.

@philippfromme philippfromme marked this pull request as draft August 26, 2024 11:27
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Aug 26, 2024
@philippfromme philippfromme marked this pull request as ready for review August 26, 2024 11:28
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 26, 2024
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikku
Copy link
Member

nikku commented Aug 26, 2024

@philippfromme I'll go ahead and release this 🤝

@nikku nikku merged commit 0cad7a9 into main Aug 26, 2024
9 of 10 checks passed
@nikku nikku deleted the version-tag branch August 26, 2024 12:34
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 26, 2024
@nikku
Copy link
Member

nikku commented Aug 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants