Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only show priority assignment in zeebe:userTask #1077

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix: only show priority assignment in zeebe:userTask #1077

merged 1 commit into from
Sep 13, 2024

Conversation

Skaiir
Copy link
Contributor

@Skaiir Skaiir commented Sep 11, 2024

Related to #21772

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 11, 2024
@Skaiir Skaiir requested review from a team, philippfromme and jarekdanielak and removed request for a team September 11, 2024 13:01
nikku
nikku reviewed Sep 11, 2024
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit-pick: I'd consolidate the "is this a relevant task" into a single utility.

@Skaiir Skaiir force-pushed the 21772-job-worker-shouldnt-configure-priority branch from 5376d87 to e756acc Compare September 12, 2024 10:37
@Skaiir Skaiir requested a review from nikku September 12, 2024 10:41
@Skaiir Skaiir force-pushed the 21772-job-worker-shouldnt-configure-priority branch from e756acc to e85bbeb Compare September 13, 2024 09:06
nikku
nikku approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 🚀

@nikku nikku merged commit 86d8c39 into main Sep 13, 2024
10 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 13, 2024
@nikku nikku deleted the 21772-job-worker-shouldnt-configure-priority branch September 13, 2024 10:20
@nikku
Copy link
Member

nikku commented Sep 13, 2024 •
edited
Loading

We still need to ensure this field is removed when the user switches the types (via https://github.com/camunda/camunda-bpmn-js-behaviors). It otherwise remains in the XML.

@nikku
Copy link
Member

nikku commented Sep 13, 2024

Released via https://github.com/bpmn-io/bpmn-js-properties-panel/releases/tag/v5.23.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme philippfromme was automatically assigned from bpmn-io/modeling-dev

@jarekdanielak jarekdanielak Awaiting requested review from jarekdanielak jarekdanielak was automatically assigned from bpmn-io/modeling-dev

Assignees

@Skaiir Skaiir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Skaiir @nikku